Skip to content

bugfix(thingfactory): Reset next ThingTemplate ID after clearing custom map template overrides to avoid CRC mismatch in the next multiplayer game session #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xezon merged 8 commits into from
Jan 3, 2026
Merged

bugfix(thingfactory): Reset next ThingTemplate ID after clearing custom map template overrides to avoid CRC mismatch in the next multiplayer game session #2034

xezon merged 8 commits into from
Jan 3, 2026

Conversation

@Caball009
Copy link

@Caball009 Caball009 commented Dec 25, 2025 •
edited
Loading

Currently, each TemplateThing gets assigned a unique ID, but the ID is not reset after each map. This can cause mismatches when playing a multiplayer match after having loaded a custom map or custom shellmap that generates TemplateThings.

TODO:

  • Need to check if relying on the hash map size is possible with STLport.
    std::hash_map::resize is the equivalent to std::unordered_map::reserve, so that's not an issue here.
  • Replicate in Generals

@Caball009 Caball009 added Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Stability Concerns stability of the runtime labels Dec 25, 2025
@Caball009 Caball009 marked this pull request as ready for review December 25, 2025 23:50
@Caball009 Caball009 changed the title bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after playing custom maps bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after loading a custom map Dec 25, 2025
Caball009
Caball009 commented Dec 29, 2025
View reviewed changes
xezon
xezon reviewed Dec 31, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. Issue description is logical.

@xezon xezon changed the title bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after loading a custom map bugfix(thingfactory): Reset next ThingTemplate ID after clearing custom map template overrides to avoid mismatches in the next multiplayer game session Jan 2, 2026
@xezon xezon changed the title bugfix(thingfactory): Reset next ThingTemplate ID after clearing custom map template overrides to avoid mismatches in the next multiplayer game session bugfix(thingfactory): Reset next ThingTemplate ID after clearing custom map template overrides to avoid CRC mismatch in the next multiplayer game session Jan 2, 2026
@xezon xezon added this to the Major bug fixes milestone Jan 2, 2026
xezon
xezon approved these changes Jan 2, 2026
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be replicated in Generals.

@Caball009
Copy link
Author

Caball009 commented Jan 2, 2026

Replicated in Generals.

@xezon xezon merged commit 409fed2 into TheSuperHackers:main Jan 3, 2026
24 checks passed
@Caball009 Caball009 deleted the fix_mismatch_thingtemplate_id branch January 3, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

Assignees

No one assigned

Labels

Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Stability Concerns stability of the runtime

Projects

None yet

Milestone

Major bug fixes

Development

Successfully merging this pull request may close these issues.

Mismatch in ThingTemplate ID after playing a map with map.ini with custom objects

2 participants

@Caball009 @xezon